Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement quality of life fixes #63

Merged
merged 4 commits into from
Jul 29, 2020
Merged

Implement quality of life fixes #63

merged 4 commits into from
Jul 29, 2020

Conversation

polsys
Copy link
Owner

@polsys polsys commented Jul 28, 2020

  • Bug fix: cond preprocessing was not done per-column; I had this in an earlier version but it was lost in some refactoring
  • Bug fix: entropy estimation with both mask and cond now works
  • Fixed Consider support for numpy masked arrays #16 by not adding support for masked arrays. Instead, added a drop_nan parameter. This has the benefit of working nicely also with pandas and pure Python data types.
  • Fixed Support separate lags for each conditioning variable #30 by adding support for separate lags for each conditioning variable. This is done by passing a 2D array (1D arrays are not promoted for consistency).

@polsys polsys added this to the Beta 1 milestone Jul 28, 2020
@polsys polsys marked this pull request as ready for review July 29, 2020 07:43
@polsys polsys merged commit eed254c into master Jul 29, 2020
@polsys polsys deleted the quality-of-life branch July 29, 2020 07:43
@polsys
Copy link
Owner Author

polsys commented Jul 29, 2020

This might have introduced a small performance regression on the real-world code I'm using, but it's hard to say for sure (lots of noise) and the benchmarks and integration tests show no difference. Anyways it's better than Alpha2...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support separate lags for each conditioning variable Consider support for numpy masked arrays
1 participant