-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libsoundio + libsndfile audio backend #33
Open
archseer
wants to merge
59
commits into
master
Choose a base branch
from
soundio
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…udio gem Moved gorilla linker line into the gorilla audio gem
I totally forgot about it
Less cache hits now, hopefully
We don't need them.
In case it wasn't defined before
Added missing headers and corrected function prototypes
Also only loop over the number of frames we've read (instead of the empty parts).
Because different systems
… gardening Originally I did a thing with music, buuuut, because of the rebase, all of it was pointless
It plays back really fast and weird
This assumes we always want to play stereo (no 5.1 or 7.1)
Removed hardcoded paths and bits of unused code
…me reason Use glm::clamp instead, that we have
Merged in some important upstream changes
There is a very good reason for this, I think...
Eh em, butchered AUDIO. Went on a refactor spree and forgot to commit piece by piece. Attempted to setup Music looping and ran into an issue where the current position of the stream could not be obtained (I didn't look that hard either...)
#include <mruby/data.h> | ||
#include <mruby/string.h> | ||
#include <mruby/variable.h> | ||
#include "moon/mrb/helpers/class.hxx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this good? Now we just have more files to look at...
Well, that's what you get for forgetting to commit in between. This reverts commit 4053f5b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.