Improve error on malformed known_package_places #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current traceback on a bad known_package_places file doesn’t make it immediately obvious that it’s a local file’s JSON that has been garbled rather than a response from AURweb or elsewhere that’s gone awry. This commit adds a single message to the JSON decode error to note which file the error is happening in and the user can then either delete the file or try and fix it, depending on the state of the file in question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current traceback on a bad known_package_places file doesn’t make it immediately obvious that it’s a local file’s JSON that has been garbled rather than a response from AURweb or elsewhere that’s gone awry.
This commit adds a single message to the JSON decode error to note which file the error is happening in and the user can then either delete the file or try and fix it, depending on the state of the file in question.