Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rest examples for stocks, options, indices, forex, and crypto #114

Merged
merged 7 commits into from
Aug 11, 2023

Conversation

justinpolygon
Copy link
Contributor

@justinpolygon justinpolygon commented Jul 14, 2023

Working on flushing out the examples here. There are still some issues to be resolved and I'm working on it.

This also depends on the following:

@justinpolygon
Copy link
Contributor Author

Hey @mmoghaddam385, wanted to get some feedback here. I wanted to add rest/websocket examples for everything and was thinking about how to logical split that up. I've come up with this but wanted to get your thought. My thinking, is that people can turn on and off things via the KotlinSample app, run gradlew, test things out, and if they want the code they can go into the specific examples.

@mmoghaddam385
Copy link
Contributor

Hey @mmoghaddam385, wanted to get some feedback here. I wanted to add rest/websocket examples for everything and was thinking about how to logical split that up. I've come up with this but wanted to get your thought. My thinking, is that people can turn on and off things via the KotlinSample app, run gradlew, test things out, and if they want the code they can go into the specific examples.

This seems like a good plan, I like separating the examples out into their own files 👍

@justinpolygon
Copy link
Contributor Author

Hey @mmoghaddam385, wanted to get some feedback here. I wanted to add rest/websocket examples for everything and was thinking about how to logical split that up. I've come up with this but wanted to get your thought. My thinking, is that people can turn on and off things via the KotlinSample app, run gradlew, test things out, and if they want the code they can go into the specific examples.

This seems like a good plan, I like separating the examples out into their own files 👍

Perfect, thank you. I'll flush this out.

justinpolygon added a commit that referenced this pull request Jul 22, 2023
Updated the readme with some examples. This PR depends on #116 and #114.
@justinpolygon justinpolygon mentioned this pull request Jul 22, 2023
@justinpolygon justinpolygon changed the title [WIP] Added rest/ws examples for stocks, options, indices, forex, and crypto [WIP] Added rest examples for stocks, options, indices, forex, and crypto Jul 22, 2023
@justinpolygon justinpolygon changed the title [WIP] Added rest examples for stocks, options, indices, forex, and crypto Added rest examples for stocks, options, indices, forex, and crypto Jul 22, 2023
@justinpolygon justinpolygon marked this pull request as ready for review July 22, 2023 21:52
Copy link
Contributor

@mmoghaddam385 mmoghaddam385 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinpolygon justinpolygon merged commit 4caeb47 into master Aug 11, 2023
@justinpolygon justinpolygon deleted the jw-examples-jvm branch August 11, 2023 17:16
justinpolygon added a commit that referenced this pull request Aug 11, 2023
Updated the readme with some examples. This PR depends on #116 and #114.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants