-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: "exact" matching mode #61
Comments
This seems like something that could fall under the umbrella of "solved by inheritance." For example, a user could implement a |
Maybe...I tried to dive in and build a simple app structure (the Polymer Starter Kit routes) using Might be missing an obvious way to make that work well -- how would you approach it? |
We spent very little time designing matching semantics for That said, in your case you can bind to the |
Fair enough. If you think inheritance is a better way to go about this, please feel free to close. |
@rictic what are your thoughts on this? |
IMO we do want the matching syntax to be reasonably flexible by 1.0, especially if it's a common problem (like this is), and the next best alternative isn't great (which I'm not yet totally sold on for this case). I was chatting in the slack channel with @TimvdLippe who's also been looking into integrating carbon-route and PSK. The solution we went with was that the main page should could be updated to use I like this because it encourages building modular elements. If it's still awkward with that use case then I think the case is stronger that we should implement a match-end-of-route feature in My perspective in a tl;dr: this seems reasonable, but we want to keep the base carbon-route super small and simple, so we'd like to hear more use cases. No matter what we do for |
Thanks for the suggested solution approaches! Just to share my experience: I bumped into the |
@rictic - Encouraging modular elements is definitely a good point. But would sub routing work also with |
It seems like it would be nice to have an
exact
boolean attribute that would exclude tail matching and require that the whole URL matches the remaining path. For instance, if I have a list and show for users I might want something like:Without
exact
, there is never a circumstance in which the first route is matched but the second isn't.If I'm misunderstanding the intended way to structure these routes (entirely probable) feel free to show me how I might approach the above in a more as-intended way. 😄
The text was updated successfully, but these errors were encountered: