Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Suggestinator to Strategizer #168

Closed
mariakleiner opened this issue Jun 20, 2017 · 2 comments
Closed

Rename Suggestinator to Strategizer #168

mariakleiner opened this issue Jun 20, 2017 · 2 comments
Assignees

Comments

@mariakleiner
Copy link
Contributor

or Strateginator? :)
This is to avoid confusion between "suggestions" that currently mean suggested plans and "suggestions" that are currently named "descriptions". After this is done, description-generator should be renamed to suggestions-generator (or suggestinator?)

Shane, Doug, please, let me know when is a good time to do the renaming to not interfere with any of your work in progress, thanks!

@mariakleiner mariakleiner self-assigned this Jun 20, 2017
@dstoc
Copy link
Contributor

dstoc commented Jun 21, 2017

I was landing the strategizer with the new name, then planning to remove the old suggestinator when it was ready to switch over, but I see how that might get in your way. But it's fine to just rename suggestinator.js to old-suggestinator.js or something. I don't think we need to rename any of the classes since they will just be removed later.

@mariakleiner
Copy link
Contributor Author

oops, i seem to have totally missed this - fea7b79
i guess, i just hold off renaming descriptions to suggestions until the new strategizer replaces the old suggestinator. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants