Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting rid of the <interleaved-list> hack #299

Closed
noelutz opened this issue Aug 16, 2017 · 1 comment
Closed

Getting rid of the <interleaved-list> hack #299

noelutz opened this issue Aug 16, 2017 · 1 comment
Assignees
Milestone

Comments

@noelutz
Copy link
Contributor

noelutz commented Aug 16, 2017

No description provided.

@noelutz noelutz added this to the v0.1 - call it done milestone Aug 16, 2017
@mariakleiner mariakleiner self-assigned this Aug 16, 2017
@sjmiles
Copy link
Contributor

sjmiles commented Aug 29, 2017

I think I voiced the idea that became this issue, but in hindsight I realize I hadn't really capture the goal I was aiming for. My intent was less specifically about then about improving the particle-developer-facing experience in the domain of set-slots.

Specifically, what's in my head is the ability for a Particle to declare and render, anywhere and in any quantity, a slot with (1) a slot id and (2) a token to identify an Entity (from one of the Particle's input lists).

So, for example, a Particle that takes a list of Product could produce any number of annotation slots and associate each slot with a particular Entity. Then Particles that can consume that Entity type and slot type can be used to render that slot.

Maria is working on this issue, but the current solution is only partial (she has successfully removed interleaved-list so technically has satisfied the issue!) IMO, it's ok to use the partial solution to satisfy this issue for purposes of milestone tracking, as long as we as sure to capture the overall issue going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants