Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

gulp-crisper: ignoring relative path #7

Closed
lukszy opened this issue Jun 26, 2015 · 4 comments
Closed

gulp-crisper: ignoring relative path #7

lukszy opened this issue Jun 26, 2015 · 4 comments

Comments

@lukszy
Copy link

lukszy commented Jun 26, 2015

When using without vulcanize.js gulp-crisper seams to ignore relative paths ex

return gulp
     .src('./app/**/*.html') // same with base option
     .pipe(crisper())
     .pipe(gulp.dest('./build/');

output

./app/elements/list/list.html -> ./build/list.html
./app/tmpl/template.html -> ./build/template.html

@Scarygami
Copy link
Contributor

Encountered the same issue, the problem is this line in gulp-crisper/index.js

path: path.join(file.base, filename)

file.base would be ./app so the resulting files have all path information in between lost.

Everything works as expected when you change the line like this

path: path.join(path.dirname(file.path), filename)

Will send a PR to https://github.com/ragingwind/gulp-crisper later.

@Scarygami
Copy link
Contributor

PR sent: ragingwind/gulp-crisper#3

If you want you can use my fork until the PR is merged and the new version published.

npm install git+https://git@github.com/scarygami/gulp-crisper.git --save-dev

@Scarygami
Copy link
Contributor

This is merged and published now. Should work correctly if you update to version 0.0.5 of gulp-crisper

@ebidel
Copy link
Contributor

ebidel commented Aug 24, 2015

Closing :)

@ebidel ebidel closed this as completed Aug 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants