Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a comment field on genotypes #1599

Closed
kimrutherford opened this issue Aug 16, 2018 · 11 comments
Closed

Consider adding a comment field on genotypes #1599

kimrutherford opened this issue Aug 16, 2018 · 11 comments

Comments

@kimrutherford
Copy link
Member

It could be very similar to the background.

@kimrutherford
Copy link
Member Author

On the last PHI-Canto call @CuzickA mentioned a case where having a comment field for genotypes might be useful for PHI-Base too. I think it was when a region is deleted from a chromosome.

@ValWood
Copy link
Member

ValWood commented Feb 9, 2019

we also had a low priority ticket for this
#1278
which I'm closing as "duplicate"

@kimrutherford
Copy link
Member Author

This issue says "Consider" in the title and has the "discuss" label. Should we definitely make this change or does it still discussion?

@ValWood
Copy link
Member

ValWood commented Mar 22, 2019

Its definitely required.

@kimrutherford
Copy link
Member Author

I've added a comment field for genotypes. Comments can be added or edited in the same places as the background, the genotype edit page or in the menu on the right of the genotype lists:


genotype-comment-2


genotype-comment-3

@kimrutherford
Copy link
Member Author

The change is now live on the fly-canto test server. eg. https://curation.pombase.org/flybase-test/curs/e974e992ec7e2aad/genotype_manage

The comment isn't visible in the genotype tables so it's quite hidden. We should talk about that.

@vmt25
Copy link

vmt25 commented Apr 2, 2019

note on usage in Fly-Canto: this will be used for phenotype free text

@vmt25
Copy link

vmt25 commented Apr 2, 2019

This 'comment' is the summary of the allele's phenotypes found in a publication. Thus, it should be associated with the allele-publication, instead of being a general comment on the allele

It would be nice if the field could be more easily accessed and more visible once a comment has been made

kimrutherford added a commit that referenced this issue May 22, 2019
Also rename to "Comment ..." for clarity

Refs #1872
Refs #1599
@vmt25
Copy link

vmt25 commented May 30, 2019

This is for after sorting genotypes (#976) and genetic interactions

kimrutherford added a commit that referenced this issue May 31, 2019
@kimrutherford
Copy link
Member Author

Is there anything else to do here?

@vmt25
Copy link

vmt25 commented Jun 11, 2019

Fly-Canto will need long-ish text fields for phenotypes (and genetic interactions).
I thought this was the ticket for it, but better to close this one and open another with a more descriptive title.

@vmt25 vmt25 closed this as completed Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants