Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allele synonyms for Fly-canto #1816

Closed
vmt25 opened this issue Apr 2, 2019 · 14 comments
Closed

Allele synonyms for Fly-canto #1816

vmt25 opened this issue Apr 2, 2019 · 14 comments

Comments

@vmt25
Copy link

vmt25 commented Apr 2, 2019

Allow for alleles synonyms used in a publication to be displayed in a separate column in the 'Single allele genotypes' table.

This requires:
A) A new field in the database?
B) Changes to the JSON import file from FlyBase (something like an 'allele synonym' field)
C) Changes to Canto's 'Single allele genotypes' table
D) do not show synonyms that are the same as the gene symbol

(Could not find any older related issue, so creating this one - feel free to edit/move it to any relevant ticket)

@mah11
Copy link
Member

mah11 commented Apr 2, 2019

I knew there were tickets somewhere ... some are closed, and one is open on our Chado tracker:

#480 has some relevant info, as does #269

pombase/pombase-chado#400 is open and linked to #1744

Leave this one open too, though, because the others don't cover the publication-specific aspect (they only refer to connecting a synonym with an allele globally).

@kimrutherford
Copy link
Member

I've added allele synonyms to the schema and altered the JSON importer (#1779) to handle synonyms and to store them correctly. The synonyms aren't displayed yet. I'll do that soon.

@kimrutherford
Copy link
Member

Allow for alleles synonyms used in a publication to be displayed

Hi Vitor. Just to check, will you be only displaying synonyms from the current publication in Canto and not synonyms from other publications?

@vmt25
Copy link
Author

vmt25 commented Apr 9, 2019

Allow for alleles synonyms used in a publication to be displayed

Hi Vitor. Just to check, will you be only displaying synonyms from the current publication in Canto and not synonyms from other publications?

Yes, only synonyms for the current publication (which will be provided on the JSON file)

@kimrutherford
Copy link
Member

For PomBase I think we'll need to:

  • add / view / remove allele synonyms from the current paper
  • view synonyms from other papers

kimrutherford added a commit that referenced this issue Apr 11, 2019
kimrutherford added a commit that referenced this issue Apr 11, 2019
kimrutherford added a commit that referenced this issue Apr 11, 2019
@kimrutherford
Copy link
Member

I think all the code is now in place to load allele synonyms from the JSON file to display them in the allele dialog and in the genotype details list.

We at PomBase will have a discussion about allele synonym editing.

kimrutherford added a commit that referenced this issue Apr 11, 2019
@ValWood
Copy link
Member

ValWood commented Apr 18, 2019

We want to edit allele synonyms (add , remove),
want to be able to add a synonym to an existing allele.
Do we want to display allele synonyms from other sessions? yes
Any added in Canto we will know the paper.
Midori has a 2 column flat file for loading existing (one off)
Display only on the genotype page (make searchable)

@mah11
Copy link
Member

mah11 commented May 10, 2019

For PomBase, we've decided that a free-text box will do, since we only have dozens of alleles with a synonym, and a handful with 2 or 3.

  • admin only
  • "edit" link or symbol brings up the box, with any existing synonym(s) editable, and room to add more

kimrutherford added a commit that referenced this issue May 14, 2019
@kimrutherford
Copy link
Member

You can now add and edit allele synonyms.

"edit" link or symbol brings up the box, with any existing synonym(s) editable, and room to add more

I decided to just put the box inline as it was easier. Let me know if that's OK.

"Existing synonyms" are those from other papers and "New synonyms" are the ones for the current paper. Both of those labels could be improved.

The "New synonyms" field is only visible in admin mode. The "Existing synonyms" field is visible is admin mode and if there are any synonyms. I think I'll change that though as you probably don't need to see "Existing synonyms: (none) in every dialog box.

edit-allele-synonyms-1

This is how the synonyms are displayed currently. Let me know how you'd like to see them:

edit-allele-synonyms-2

@kimrutherford
Copy link
Member

@ValWood, @mah11, @Antonialock let me know if this works OK.

I've added separate issues for showing existing allele synonyms (#1880) and for storing the new synonyms in Chado (pombase/pombase-chado#731).

@kimrutherford
Copy link
Member

@ValWood, @mah11, @Antonialock let me know if this works OK.

Also, could you let me know when you start adding allele synonyms so I can check that they are exported correctly from Canto? And so I have an example for testing importing into Chado: pombase/pombase-chado#731

@ValWood
Copy link
Member

ValWood commented May 28, 2019

I'm unable to test this because I can't find our record of allele synonyms. I'm not sure if we have one? I thought we did but I can't see anything on this tracker or the curation tracker.

@vmt25
Copy link
Author

vmt25 commented May 30, 2019

The synonyms look good; no more is needed for FlyBase purposes

@ValWood
Copy link
Member

ValWood commented Jun 13, 2019

I'm closing this. I'm not quite sure where we are at but I know it is working so if problems, new tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants