Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Notes are editable in approved sessions #2204

Closed
vmt25 opened this issue Jan 28, 2020 · 3 comments
Closed

bug: Notes are editable in approved sessions #2204

vmt25 opened this issue Jan 28, 2020 · 3 comments
Assignees
@kimrutherford
Labels
bug FlyBase

Comments

@vmt25
Copy link

vmt25 commented Jan 28, 2020

Currently notes can be changed in approved sessions, which should be read-only, right? At least that is not the behavior I was expecting.

(Not sure this behavior is limited to Fly-Canto)
kimrutherford added a commit that referenced this issue Jan 29, 2020
@kimrutherford
Restore missing allele comments
cb63c98 
Refs #2204
@kimrutherford
Copy link
Member

While looking into this I noticed that the code to display internal notes (that we import via the JSON file - #1779) was broken and the notes weren't being displayed. I've fixed that.

kimrutherford added a commit that referenced this issue Jan 29, 2020
@kimrutherford
Make genotype notes read-only in /ro mode
c5b7848 
Refs #2204
@kimrutherford
Copy link
Member

Currently notes can be changed in approved sessions, which should be read-only, right?

Yep! They should be read-only. I've fixed that.

@vmt25
Copy link
Author

vmt25 commented Jan 30, 2020

Looks fine - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kimrutherford kimrutherford

Labels
bug FlyBase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimrutherford @vmt25