-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter options for single, multi allele genotypes in query builder #405
Comments
Yes this should be top priority for Thursday call.... and this ties in |
Important:
|
I had a brief look at the PECO terms and I'm struggling to come up with meaningful groupings. |
I think we have problems whichever way we do it. I wonder if we could begin with some very general |
I don't like the idea of lumping "standard conditions"...there are no standard conditions really....a person might think of "YES" and standard medium because it has everything WT yeast needs, and EMM as a "starvation medium" This might be difficult to implement but my preference would be to run the query, and get the result list. some text would say "these annotations have been associated with these conditions, are there any that you would like to exclude or include" we could organise them under a few headers, and for the temperature and growth medium headers we could offer to include or exclude anything where this was not recorded. So it is like a filtering step after you have run the query. |
Yes, negative filtering is definitely required, and post query filtering would be neat... I still thing we would probably need a "restricted list" so we omit the chemicals which are only used to assess sensitivity (maybe). Or something even cleverer. Anyway "conditions" can be "post release" as we continue to think about it.... |
I'm working on the single vs multi-allele and expression filtering first to give us more time to decide what to do about the conditions. |
I've added single and multi allele checkboxes for phenotype searches in the query builder. It currently looks like this:
Please let me know if you have ideas for improving how it looks or works. |
Yep, that's sounds like a good way to do it as it will mostly keep the list of possible conditions to a manageable size. It's trickier though. :-) |
I've add allele expression filtering, hopefully in the way you wanted. It looks like: Please let me know if you find any problems. And as usual, any suggestions for formatting or wording would be very helpful. For example one of the labels is currently "Wild type + overexpression". Can you suggest a better way to word it? Maybe "Overexpressed wild type"? Looking at the screenshot I noticed that the text isn't aligned on the right. I'll fix that. |
I don't like this...for example, you might annotate a gene to an "elongated" phenotype +chemical_commonly_used_in_sensitivity_screens you might want to filter those out.... |
I'm sure that for some genes it would still be long :-) this filtering section could be expandable so that if you only see them if you want to do the filtering (this is how it is done in the biomart...not suggesting we replicate exactly how it looks, but I like that it is collapsible so you don't get presented with a huge form) |
Overexpressed wild type sounds better than WT+overexpression... |
I've changed that. |
I like that too. |
So, it seems this ticket is now about condition filtering, so I will change the title. |
I think the relevent parts of the discussion are not on the "conditions filtering" ticket |
duplicate |
From Val:
(rather than just showing the genes from the single allele genotype annotation in the results)
The text was updated successfully, but these errors were encountered: