Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter options for single, multi allele genotypes in query builder #405

Closed
kimrutherford opened this issue Jun 21, 2017 · 19 comments
Closed

Comments

@kimrutherford
Copy link
Member

From Val:

maybe we want to include all and have "single-allele" "multi-allele" as filter options?

(rather than just showing the genes from the single allele genotype annotation in the results)

@ValWood
Copy link
Member

ValWood commented Jul 23, 2017

Yes this should be top priority for Thursday call....

and this ties in
pombase/curation#1407

@ValWood
Copy link
Member

ValWood commented Jul 27, 2017

  1. Single or multigene allele (or all)

  2. allele expression (show only for single-allele genotypes)
    default all
    null (deletion+ anything with expression null)
    wild type + overexpression

  3. conditions
    auto complete?
    set of options....
    standard conditions/ non standard
    Look at condition ontology and make a slim?
    chemical sensitivity?
    temperature?
    growth medium?
    conditional?

Important:
How to deal with the incompleteness of annotation
not recorded would be lumped with "standard"
i.e standard temperature will included everything with standard temperature and where the temperature is "not stated"

  1. We will want the filter for conditions to also appear on the gene pages....

@mah11
Copy link
Member

mah11 commented Jul 27, 2017

@ValWood
Copy link
Member

ValWood commented Jul 27, 2017

I had a brief look at the PECO terms and I'm struggling to come up with meaningful groupings.
Any ideas....

@ValWood
Copy link
Member

ValWood commented Jul 27, 2017

I think we have problems whichever way we do it.
Even conditional isn't really possible. Fr instance I have rarely used permissive/non-permissive as I have et the user figure that out from the combination of phenotype and condition....

I wonder if we could begin with some very general
standard non standard growth condition groupings, but many would be difficult to partition. I'm a bit stuck. Especially when i also start to think that we don't always know and how that might affect results...

@Antonialock
Copy link
Member

I don't like the idea of lumping "standard conditions"...there are no standard conditions really....a person might think of "YES" and standard medium because it has everything WT yeast needs, and EMM as a "starvation medium"
Another might think of EMM as standard because it is defined

This might be difficult to implement but my preference would be to run the query, and get the result list. some text would say "these annotations have been associated with these conditions, are there any that you would like to exclude or include"

we could organise them under a few headers, and for the temperature and growth medium headers we could offer to include or exclude anything where this was not recorded.

So it is like a filtering step after you have run the query.

@ValWood
Copy link
Member

ValWood commented Jul 28, 2017

Yes, negative filtering is definitely required, and post query filtering would be neat...

I still thing we would probably need a "restricted list" so we omit the chemicals which are only used to assess sensitivity (maybe). Or something even cleverer.

Anyway "conditions" can be "post release" as we continue to think about it....

@kimrutherford
Copy link
Member Author

I'm working on the single vs multi-allele and expression filtering first to give us more time to decide what to do about the conditions.

kimrutherford added a commit that referenced this issue Jul 28, 2017
kimrutherford added a commit that referenced this issue Jul 28, 2017
kimrutherford added a commit to pombase/pombase-chado-json that referenced this issue Jul 28, 2017
kimrutherford added a commit to pombase/pombase-chado-json that referenced this issue Jul 28, 2017
@kimrutherford
Copy link
Member Author

I've added single and multi allele checkboxes for phenotype searches in the query builder.

It currently looks like this:

Include genes from:  [ ] Single-allele genotypes [ ] multi-allele geneotypes

Please let me know if you have ideas for improving how it looks or works.

@kimrutherford
Copy link
Member Author

This might be difficult to implement but my preference would be to run the query, and get the result list.

Yep, that's sounds like a good way to do it as it will mostly keep the list of possible conditions to a manageable size. It's trickier though. :-)

kimrutherford added a commit to pombase/pombase-chado-json that referenced this issue Jul 31, 2017
kimrutherford added a commit that referenced this issue Jul 31, 2017
kimrutherford added a commit that referenced this issue Jul 31, 2017
kimrutherford added a commit to pombase/pombase-chado-json that referenced this issue Jul 31, 2017
kimrutherford added a commit to pombase/pombase-chado-json that referenced this issue Jul 31, 2017
@kimrutherford
Copy link
Member Author

I've add allele expression filtering, hopefully in the way you wanted. It looks like:

screenshot from 2017-08-01 00-00-57

Please let me know if you find any problems. And as usual, any suggestions for formatting or wording would be very helpful. For example one of the labels is currently "Wild type + overexpression". Can you suggest a better way to word it? Maybe "Overexpressed wild type"?

Looking at the screenshot I noticed that the text isn't aligned on the right. I'll fix that.

@Antonialock
Copy link
Member

I still thing we would probably need a "restricted list" so we omit the chemicals which are only used to assess sensitivity (maybe). Or something even cleverer.

I don't like this...for example, you might annotate a gene to an "elongated" phenotype +chemical_commonly_used_in_sensitivity_screens

you might want to filter those out....

@Antonialock
Copy link
Member

Yep, that's sounds like a good way to do it as it will mostly keep the list of possible conditions to a manageable size

I'm sure that for some genes it would still be long :-) this filtering section could be expandable so that if you only see them if you want to do the filtering (this is how it is done in the biomart...not suggesting we replicate exactly how it looks, but I like that it is collapsible so you don't get presented with a huge form)

screen shot 2017-08-03 at 09 48 28

@Antonialock
Copy link
Member

Overexpressed wild type sounds better than WT+overexpression...

@kimrutherford
Copy link
Member Author

Overexpressed wild type sounds better than WT+overexpression...

I've changed that.

@kimrutherford
Copy link
Member Author

but I like that it is collapsible so you don't get presented with a huge form

I like that too.

kimrutherford added a commit that referenced this issue Aug 4, 2017
@pombase pombase deleted a comment from kimrutherford Aug 14, 2017
@ValWood
Copy link
Member

ValWood commented Aug 14, 2017

So, it seems this ticket is now about condition filtering, so I will change the title.
We don't need to do this for public release, the required part of multi vs single is done.

@ValWood ValWood changed the title Add filter options for single, multi allele genotypes in query builder Add filter options for conditions in query builder (formerly ticket for multi- vs single allele filtering) Aug 14, 2017
@ValWood
Copy link
Member

ValWood commented Aug 14, 2017

I think the relevent parts of the discussion are not on the "conditions filtering" ticket
#56

@ValWood ValWood changed the title Add filter options for conditions in query builder (formerly ticket for multi- vs single allele filtering) Add filter options for single, multi allele genotypes in query builder Aug 14, 2017
@ValWood
Copy link
Member

ValWood commented Aug 14, 2017

duplicate
#56

@ValWood ValWood closed this as completed Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants