Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX by marking changed lines #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/slide.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,16 @@ function getLine(line, i, { styles }) {
);
}

function getStyleWithMark(styles) {
return styles.map((item) => {
if(item.opacity && item.opacity === 1) {
item.borderLeft = "2px solid rgb(255 190 0 / 71%)";
item.paddingLeft = "6px";
}
return item
})
}

function Slide({ lines, styles, changes }) {
return (
<pre
Expand Down Expand Up @@ -64,5 +74,6 @@ function Slide({ lines, styles, changes }) {
export default function SlideWrapper({ time, version }) {
const { lines, changes } = version;
const styles = animation((time + 1) / 2, lines);
return <Slide lines={lines} styles={styles} changes={changes} />;
const stylesWithMark = getStyleWithMark(styles);
return <Slide lines={lines} styles={stylesWithMark} changes={changes} />;
}