v0.0.5 fixes

[desimone]

Fixes #3
Fixes #4 (thx @travisgroth ! desimone#1)

• confirm everything works on GKE
• ready for review

[desimone]

/cc @travisgroth two issues I'm stuck on and welcome any ideas.

1. Any ideas how to pass the GKE service annotation cloud.google.com/app-protocols: '{"https":"HTTPS"}' with the proper escapes so can pass those details in via the command line instead of with values?
2. I was hitting an error with the resources key. You can see it is removed above. I couldn't get it working. Refactor chart for new config methods #2

[travisgroth]

1. I think this will do it.

helm template . \
--set ingress.enabled=true \
--set ingress.annotations."cloud\.google\.com/app-protocols"='\{"https":"HTTPS"\}

# Source: pomerium/templates/ingress.yaml
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: release-name-pomerium
  labels:
    app.kubernetes.io/name: pomerium
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/managed-by: Tiller
    helm.sh/chart: pomerium-1.0.0
  annotations:
    cloud.google.com/app-protocols: '{"https":"HTTPS"}'
    kubernetes.io/ingress.allow-http: "false"

Funny thing here. The quotes are only needed for one of the 4 ingresses:

helm template . --set ingress.enabled=true --set ingress.annotations.cloud\.google\.com/app-protocols='\{"https":"HTTPS"\}'  | grep cloud
    cloud.google.com/app-protocols: '{"https":"HTTPS"}'
    cloud.google.com/app-protocols: '{"https":"HTTPS"}'
    cloud.google.com/app-protocols: '{"https":"HTTPS"}'
    cloud:

Edit: Ah there's only one ingress obviously. the toYaml is messing it up without the quotes.

[travisgroth]

2. The resource block needs to move over two spaces. Fix resource indentation desimone/pomerium-helm#1

3. It looks like there will also be a conflict between the config volume and extravolumes if you specify both right now. I don't have time to reason through the change right now, but it is unlikely to be hit in the near term.

[desimone]

\cc @victornoel @travisgroth if you don't mind giving this another look. This is what I'll merged (see updated tag) after v0.0.5 drops.

[victornoel]

@desimone if you can wait I will test this version of the chart with the latest build on Monday

[desimone]

Absolutely

…

On Jun 1, 2019, at 10:38 AM, Victor Noël ***@***.***> wrote: @desimone if you can wait I will test this version of the chart with the latest build on Monday — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[victornoel]

@desimone there is something strange with .Values.config.existingPolicy: it seems it is referenced in some place but it is never really used. I think maybe it should be completely removed?

[travisgroth]

@desimone there is something strange with .Values.config.existingPolicy: it seems it is referenced in some place but it is never really used. I think maybe it should be completely removed?

I must've introduced that while reworking the chart. I agree - I don't believe it makes sense anymore in the current state of things. An existing CM for just policy wouldn't make much sense. (1) config.existingConfig covers that and (2) config.policy is inlined to the in-chart CM.

[victornoel]

@desimone I think when you force-pushed yesterday you undid some of the change you had done: https://github.com/pomerium/pomerium-helm/compare/cb1b10c89fa9c49cfa2d0de7a6d608a587cf0ee2..95d2757b184bc0a8af3c0b597beaed890df78b3f

[desimone]

@victornoel Thank you. I totally did.