Signing key in secret #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tgomas
force-pushed
the
signing-key-secret
branch
5 times, most recently
from
d5a32eb
to
979501e
Compare
victornoel
reviewed
Mar 3, 2020
tgomas
force-pushed
the
signing-key-secret
branch
3 times, most recently
from
7bfc092
to
02597e4
Compare
victornoel
reviewed
Mar 16, 2020
victornoel
reviewed
Mar 16, 2020
victornoel
reviewed
Mar 16, 2020
victornoel
reviewed
Mar 16, 2020
tgomas
commented
Mar 16, 2020
tgomas
force-pushed
the
signing-key-secret
branch
2 times, most recently
from
bf25e0b
to
9ea4dbc
Compare
travisgroth
reviewed
Mar 17, 2020
tgomas
force-pushed
the
signing-key-secret
branch
from
9ea4dbc
to
9cfbc8c
Compare
victornoel
reviewed
Mar 17, 2020
victornoel
reviewed
Mar 17, 2020
victornoel
reviewed
Mar 17, 2020
victornoel
reviewed
Mar 17, 2020
tgomas
force-pushed
the
signing-key-secret
branch
from
9cfbc8c
to
173a527
Compare
victornoel
reviewed
Mar 17, 2020
tgomas
force-pushed
the
signing-key-secret
branch
2 times, most recently
from
d5e5abc
to
cf30710
Compare
This was referenced Mar 23, 2020
Merged
victornoel
reviewed
Mar 23, 2020
victornoel
reviewed
Mar 23, 2020
Signed-off-by: Thomas Sontheimer <tgomas@users.noreply.github.com>
Signed-off-by: Thomas Sontheimer <tgomas@users.noreply.github.com>
Signed-off-by: Thomas Sontheimer <tgomas@users.noreply.github.com>
Signed-off-by: Thomas Sontheimer <tgomas@users.noreply.github.com>
tgomas
force-pushed
the
signing-key-secret
branch
from
cf30710
to
a8b0ce5
Compare
|
@travisgroth all comments have been processed: signing-key can be generated at install and is stored in a dedicated secret. Could you please help me to get it merged ? I'm still open to improve it if you have any additional comment. |
|
@tgomas FYI, I had to unpublish 6.0.5 as this does actually cause a breaking change to existing charts. I'm going to re-release as 7.0.0. That's my mistake for not catching it. I will also add instructions similar to what we had for the 5.x release https://github.com/pomerium/pomerium-helm/tree/master/charts/pomerium#500-1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a proposition to add a
proxy.signingKeyparameter which is stored in the secret.close #65