Skip to content
This repository has been archived by the owner on Sep 20, 2022. It is now read-only.

Upgrade kube dependencies to v1.19 #113

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

travisgroth
Copy link
Contributor

@travisgroth travisgroth commented Apr 2, 2021

Summary

Upgrade to kubernetes 1.19 and related packages. This needed to be done eventually anyway, but for the full set of ingress path specification fields, we need to be on 1.19.

The upgrade did introduce some new method signatures and restrictions that had to be accounted for.

  • Upgrade deps
  • Switch stop channel to context/cancel
  • Stop re-using the same builder for multiple controllers
  • Implement ClientBuilder interface
  • Switch to client.Object

Related issues

#101

Checklist:

  • add related issues
  • ready for review

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #113 (a4d7961) into master (0385952) will increase coverage by 0.98%.
The diff coverage is 77.77%.

❗ Current head a4d7961 differs from pull request most recent head de94217. Consider uploading reports for the commit de94217 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   72.63%   73.61%   +0.98%     
==========================================
  Files           7        7              
  Lines         402      398       -4     
==========================================
+ Hits          292      293       +1     
+ Misses         79       76       -3     
+ Partials       31       29       -2     
Impacted Files Coverage Δ
cmd/pomerium-operator/root.go 55.35% <0.00%> (ø)
internal/controller/policy.go 81.33% <ø> (ø)
internal/operator/operator.go 66.66% <80.00%> (+3.87%) ⬆️
internal/configmanager/configmanager.go 85.71% <100.00%> (+2.38%) ⬆️
internal/controller/reconciler.go 79.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0385952...de94217. Read the comment docs.

@travisgroth travisgroth marked this pull request as ready for review April 5, 2021 14:59
@travisgroth travisgroth requested review from a team and wasaga and removed request for a team April 5, 2021 14:59
}()

close(stopCh)
cancel()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the expectation that if you immediately cancel it would already be able to store settings?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does read a little funny, but the underlying loop will persist the config before actually terminating from cancel().

@travisgroth travisgroth merged commit 133a8bc into pomerium:master Apr 5, 2021
@travisgroth travisgroth deleted the kube_1.19 branch April 5, 2021 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants