[WIP] Add support sf4 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My PR opened 8 moths ago should be merged first, and then this one rebased on top of it. |
|
+1 for this PR !!! |
stood
force-pushed
the
feature-add-support-sf4
branch
from
84c7996
to
afd134a
Compare
|
@chanmix51 can you tag CLI plz for support 4.0 ? |
sanpii
approved these changes
Dec 31, 2017
|
Ok, I think I have understood the problem with php5.4 and symfony 3/4 build. PHP 5.4 force symfony to keep in 2.8 version: https://travis-ci.org/pomm-project/pomm-bundle/jobs/323213244#L612 We need a better way to dertermine if we should launch current_version=$(composer show --format=json | jq '.installed[] | select(.name == "symfony/symfony") | .version' | sed 's/^"v\([^"]*\)"/\1/')
sf2 = $(dpkg --compare-versions "$current_version" "lt" "3"; echo $?)
test $sf2 == 0 && ./bin/behat --tags '~@upper2lts' ||./bin/behat |
sanpii
reviewed
Jan 16, 2018
.travis.yml
Outdated
| - test "$SYMFONY_VERSION" -eq 3 && composer require --no-update symfony/lts:^3||true | ||
| - cd tests/ | ||
| - test "$SYMFONY_VERSION" -eq 2 && composer require --no-update symfony/lts:^2||true | ||
| - test "$SYMFONY_VERSION" -eq 3 && composer require --no-update symfony/lts:^3||true |
There was a problem hiding this comment.
These lines can probably be merged like:
composer require --no-update "symfony/lts:^$SYMFONY_VERSION"
.travis.yml
Outdated
| @@ -36,21 +37,25 @@ before_install: | |||
|
|
|||
| - php -S localhost:8080 -t tests/web &> /dev/null & | |||
| - ln -fs parameters.yml.dist tests/app/config/parameters.yml | |||
| - test "$SYMFONY_VERSION" -eq 2 && composer require --no-update symfony/lts:^2||true | |||
| - test "$SYMFONY_VERSION" -eq 3 && composer require --no-update symfony/lts:^3||true | |||
There was a problem hiding this comment.
These lines can probably be merged like:
composer require --no-update "symfony/lts:^$SYMFONY_VERSION"
.travis.yml
Outdated
| - rm -rf vendor/pomm-project/pomm-bundle | ||
| - ln -s ../../../ vendor/pomm-project/pomm-bundle | ||
|
|
||
| script: | ||
| - ../vendor/bin/phpcs --standard=psr2 --runtime-set ignore_warnings_on_exit true --report=summary ../sources | ||
| - ./bin/behat | ||
| - test "$SYMFONY_VERSION" -eq 2 && ./bin/behat --tags '~@upper2lts' ||./bin/behat |
There was a problem hiding this comment.
A probably more readable version:
./bin/behat --tags "~@upper${current_version}lts"
sanpii
force-pushed
the
feature-add-support-sf4
branch
3 times, most recently
from
8a1a2a2
to
cc45487
Compare
sanpii
force-pushed
the
feature-add-support-sf4
branch
from
cc45487
to
ef1bcb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.