Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List collectd plugins without rrd files enumeration #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

List collectd plugins without rrd files enumeration #170

wants to merge 1 commit into from

Conversation

Self-Perfection
Copy link
Contributor

There are 2 motives for the change:

  1. Before the change CGP enumerated all rrd files to display graph.php
    or host.php and therefore broke if any single plugin directory lacks
    read permissions.

  2. With active open_basedir PHP option recursive scan becomes really
    slow. Avoiding it gives huge speedup. For example on Core i5 and ~1300
    rrd files:
    graph.php: 907 ms -> 31 ms
    host.php: 1372 ms -> 480 ms

@Self-Perfection
List collectd plugins without rrd files enumeration
31443d7 
There are 2 motives for the change:

1) Before the change CGP enumerated all rrd files to display graph.php
or host.php and therefore broke if any single plugin directory lacks
read permissions.

2) With active open_basedir PHP option recursive scan becomes really
slow. Avoiding it gives huge speedup. For example on Core i5 and ~1300
rrd files:
graph.php: 907 ms -> 31 ms
host.php: 1372 ms -> 480 ms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Self-Perfection