-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable targets exportation during build #150
Conversation
@nmellado @azaleostu I modified the cmake exportation to make the targets available during the build. Now, projects that are exported can link to Ponca. The problem only appeared with libraries. |
I also did a bit of work on the installation folder to add the Ponca name. If Ponca is installed by another project, this makes the install directory more structured. It should not interfere with the previous installation because of the cmake find_package procedure. Also, I think that the installation paths could be shared by the cmake files, they are currently hard coded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe update the changelog as this might break existing installs, otherwise looks good 👍
I need to understand why the tests didn't start. |
I think you need to approve the PR to trigger the action because I am not a contributor. https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#controlling-changes-from-forks-to-workflows-in-public-repositories |
close #149