Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding SpareTensor test #24

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Adding SpareTensor test #24

merged 3 commits into from
Jun 21, 2023

Conversation

tatianacv
Copy link
Member

@tatianacv tatianacv commented Jun 20, 2023 •
edited by khatchad
Loading

Add test case for #25.

@khatchad khatchad marked this pull request as ready for review June 20, 2023 14:21
@khatchad
Copy link
Member

I think this should work once we have #22.

@tatianacv tatianacv closed this Jun 20, 2023
@tatianacv
Copy link
Member Author

tatianacv commented Jun 20, 2023 •
edited by khatchad
Loading

I think this should work once we have #22.

It doesn't. I just tested it. We get the following error:

[ERROR]   TestTensorflowModel.testTf2:78->testTf2:102->lambda$testTf2$2:104 ClassCast class com.ibm.wala.ipa.callgraph.propagation.ReturnValueKey cannot be cast to class com.ibm.wala.ipa.callgraph.propagation.LocalPointerKey (com.ibm.wala.ipa.callgraph.propagation.ReturnValueKey and com.ibm.wala.ipa.callgraph.propagation.LocalPointerKey are in unnamed module of loader 'app')

@khatchad khatchad reopened this Jun 20, 2023
@khatchad khatchad linked an issue Jun 20, 2023 that may be closed by this pull request
Casting Issue: Getting a ReturnValueKey instead of LocalPointerKey #25
Closed
@khatchad khatchad requested a review from a team June 20, 2023 22:58
@khatchad khatchad merged commit 67f20c5 into ponder-lab:master Jun 21, 2023
@tatianacv tatianacv deleted the test_SparseTensor branch June 21, 2023 12:42
tatianacv added a commit to tatianacv/ML that referenced this pull request Jun 21, 2023
@tatianacv
Removing to do because of ponder-lab#24
6159f2d
This was linked to issues Jun 21, 2023
IllegalState when importing a second-level API directly #28
Closed
Casting Issue: Getting a InstanceFieldKey instead of LocalPointerKey #27
Closed
khatchad added a commit that referenced this pull request Dec 4, 2023
@khatchad
Add support and tests for callables (#108)
3b9be89 
Fixes #24. See
https://docs.python.org/3/reference/datamodel.html#class-instances.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khatchad khatchad khatchad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tatianacv @khatchad