Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding log for the dataflow sources #37

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Adding log for the dataflow sources #37

merged 2 commits into from
Jun 27, 2023

Conversation

tatianacv
Copy link
Member

@tatianacv tatianacv commented Jun 27, 2023 •
edited by khatchad
Loading

Fix wala#66.

khatchad
khatchad approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@khatchad khatchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@khatchad khatchad enabled auto-merge June 27, 2023 20:49
@khatchad khatchad requested a review from a team June 27, 2023 20:50
tatianacv
tatianacv commented Jun 27, 2023
View reviewed changes
Copy link
Member Author

@tatianacv tatianacv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log looks good.

@khatchad khatchad disabled auto-merge June 27, 2023 20:57
@khatchad khatchad merged commit cd669ea into master Jun 27, 2023
@khatchad khatchad deleted the adding_log branch June 27, 2023 20:57
@khatchad
Copy link
Member

@tatianacv Can you also send this upstream?

@tatianacv
Copy link
Member Author

tatianacv commented Jun 27, 2023 •
edited
Loading

@tatianacv Can you also send this upstream?

Sounds good (wala#67)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khatchad khatchad khatchad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log when adding a tensor dataflow source
2 participants
@tatianacv @khatchad