Refactor ast internal structure to store annotation more efficiently. #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now annotation and type are both stored, while only using one pointer (and one flag) rather than two pointers on the ast_t struct. This saves size in allocations, and particularly puts us in a smaller size class when it comes to the next-power-of-two size that dictates which memory pool we allocate from.
sylvanc
approved these changes
Mar 10, 2017
jemc
added a commit
that referenced
this pull request
Mar 26, 2017
Fixes a compiler assertion error.
jemc
added a commit
that referenced
this pull request
Mar 26, 2017
Fixes #1751, a compiler assertion error related to this system.
Praetonus
pushed a commit
that referenced
this pull request
Mar 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now annotation and type are both stored, while only using one pointer
(and one flag) rather than two pointers on the ast_t struct.
This saves size in allocations, and particularly puts us in a smaller
size class when it comes to the next-power-of-two size that dictates
which memory pool we allocate from.
This was discussed in #1531.