[RFC 50] add member docstrings #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was failing during check_tree due to a missing optional STRING node for the docstring
and display fields more prominently
mfelsche
added
project documentation
changelog - added
jemc
approved these changes
Feb 21, 2018
|
This is awesome! |
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
* adapt parser to accept field docstrings * fix desugaring of lambda captures as fields it was failing during check_tree due to a missing optional STRING node for the docstring * docgen: add docstring to fields docs and display fields more prominently * update pony.g for field docstrings
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the first part of RFC 50: https://github.com/ponylang/rfcs/blob/master/text/0050-class-actor-fields-docstrings.md (The second part is docgen documentation in the tutorial).
It does roughly the following
The ponylang mkdocs theme has been updated for field docstrings. Example:
fixes #2502