Do not use llvm.smul.with.overflow.i64 anymore #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfelsche
added
changelog - fixed
as it might not be available on some 32 bit systems. See also: * https://bugs.llvm.org/show_bug.cgi?id=14469 * https://bugs.llvm.org/show_bug.cgi?id=16404
|
@vassilvk confirmed on IRC that the same issue also appeared on a 32 bit ubuntu 16.04 machine. So it seems to be indeed related to 32 bit compiler runtime libraries (libgcc, compiler-rt) not providing This issue only appeared recently with the merge of #2645 but it exhibited a but that was existing beforehand when |
jemc
approved these changes
May 16, 2018
ponylang-main
added a commit
that referenced
this pull request
May 16, 2018
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
as it might not be available on some 32 bit systems. See also: * https://bugs.llvm.org/show_bug.cgi?id=14469 * https://bugs.llvm.org/show_bug.cgi?id=16404
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as it might not be available on some 32 bit systems (verified for an illumos system by @jasonbking ).
The required runtime function
__mulodi4is not available from the gcc runtime library on these systems, it seems.This change should not have any performance impact, as already verified in #2645 .
See also: