Fix memory overflow when allocating CPUs when numa is enabled #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically when numa is enabled and the count of available cpus isn't
greater than the number of numa cores.
Previously, when
```
if(avail_cpu_count > numa_count)
avail_cpu_size = numa_count;
```
was executed, then at that point avail_cpu_size was 0. this means if
`avail_cpu_count` is not greater than `numa_count` then `avail_cpu_size`
will remain 0 and:
```
ponyint_pool_alloc_size(avail_cpu_size * sizeof(uint32_t));
```
will allocate no memory and bad segfaulting things will happen.
This commit patches the bug to set `avail_cpu_size` to the CPU_COUNT
when we enter `ponyint_cpu_init`.
` avail_cpu_size = avail_cpu_count = CPU_COUNT(&all_cpus);`
Fixes #2559
Fixes #2689
SeanTAllen
added
triggers release
This was referenced Jun 5, 2018
slfritchie
approved these changes
Jun 5, 2018
|
And also this patch doesn't crash when using the reproducer recipe in #2559 on an AWS c4.8xlarge VM. |
ponylang-main
added a commit
that referenced
this pull request
Jun 5, 2018
Closed
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically when numa is enabled and the count of available cpus isn't
greater than the number of numa cores.
Previously, when
was executed, then at that point avail_cpu_size was 0. this means if
avail_cpu_countis not greater thannuma_countthenavail_cpu_sizewill remain 0 and:
will allocate no memory and bad segfaulting things will happen.
This commit patches the bug to set
avail_cpu_sizeto the CPU_COUNTwhen we enter
ponyint_cpu_init.avail_cpu_size = avail_cpu_count = CPU_COUNT(&all_cpus);Fixes #2559
Fixes #2689