Correctly handle modifier keys for TTY stdin on Windows #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard input on Windows was hanging when a modifier key (CTRL, ALT or SHIFT) was pressed. This change correctly handles the console keydown event where there is no actual character value. Fixes ponylang#2891
chalcolith
added
the
changelog - fixed
mfelsche
approved these changes
Oct 3, 2018
There was a problem hiding this comment.
Approved.
What do you think about another test suite, that compiles and runs some pony program and interacts with it, piping something to it, sending a signal etc. for testing this. Maybe in plain bash, maybe in python.
The reason for this is that in our current test suites we are always testing in-process, not how a pony process behaves.
|
Just piping to a program wouldn't catch this particular case; we'd need to write a Windows-specific wrapper that simulates keystroke events. That seems like too much work right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard input on Windows was hanging when a modifier key (CTRL, ALT or SHIFT) was pressed. This change correctly handles the console keydown event where there is no actual character value.
Fixes #2891