Remove duplication from Linux nightly and release builders #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've discussed moving to Python to remove duplication, however, this is a relatively small change that drops a ton of duplication.
|
Arm kaboom is unrelated but does remind us we have a bug in the arm code somewhere. |
|
Crash on armhf linux: Unrelated, but possibly concerning |
|
@Theodus can you see if we have an issue already for the occassional arm segfaults during CI? i think we do, if we do can you add this as another example if its not already there. otherwise can you add an issue? |
|
@Theodus it's also possibly a qemu bug. can't rule that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've discussed moving to Python to remove duplication, however, this
is a relatively small change that drops a ton of duplication.