-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 65 - change type of Env.root to be AmbientAuth #3558
Conversation
@mfelsche can you write up release notes and how to change on the next release notes? |
@mfelsche I opened a PR for the update to the tutorial: Also needing updates ready before this is merged:
|
I can do the release notes. i can also do the rest of the listed pony libraries |
@mfelsche on the release issue. |
@mfelsche please update the checklist of things to do before this can be merged as you do them. I checked off net_ssl |
We discussed this in today's sync call. Sylvan shared an example of an alternative POC approach that he came up with that would allow If someone is able to write an RFC for that approach, and we decide we like it, we may want to hold off on merging this and consider not breaking everyone's That said, this RFC has actually been accepted and the other one hasn't even been written, so I don't want to actually block this PR if @mfelsche wants to move forward with it. |
We discussed again, we would prefer the Sylvan approach as noted in the playground example in the link above. We don't plan on merging this change, however, we need an RFC to be written for the "Sylvan change" to move forward with it. |
We've opened an RFC issue for the "Sylvan approach": ponylang/rfcs#177 |
@mfelsche comments? |
The AuthSet approach is totally fine. Lets rather have this as a basis for solving issues around env. |
Closes #3557