Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Poole 2 and Jekyll 3 #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mathiasvr
Copy link

Hi, this PR brings in the changes from Poole 2 for Jekyll 3 support.

I know there are already a bunch of pending pull requests, but I am sharing this anyway in case somebody wants a working theme for Jekyll 3. Get the complete theme here.

Notes:

  • sidebar.html might need better HTML5 tags
  • hyde.css has not been converted to scss

@qwtel
Copy link

qwtel commented Feb 25, 2016

good stuff in there :)

@jilmun
Copy link

jilmun commented Feb 25, 2016

Thanks for this @mathiasvr. I made most of your updates and I'm very happy with the results. I don't have much experience in web dev, why is the baseurl change from "/" to "" in _config.yml a good idea?

@qwtel - Very cool what you've done with your site, especially the sidebar. I did have a question on small screens... if you click on the menu icon to bring up the sidebar, there's no way to get the sidebar to disappear without refreshing or clicking on one of the sidebar links right? I was thinking of trying to implement something similar for my site but I think I'd either want the expanded sidebar to take up the entire screen (or moved to top) or I'd like to have some way to close out of it if covers other portions of the content (similar to lanyon but without actually moving the content to the right).

@qwtel
Copy link

qwtel commented Feb 25, 2016

Glad you like it :) It's still work in progress and currently assumes that you are using a touch device for the small screen layout. Closing the menu bar works via swiping to the left or tapping on the backdrop.

Regarding your site, my current implementation should still work if you set .sidebar { width: 100%; left: -100%} but again it's unfinished and relies on JS (the lanyon one is CSS only which is pretty cool).

@mathiasvr
Copy link
Author

@jjwesner The updated files are based on the current version of Poole which amongst other things sets the baseurl to "". This is also the default configuration when creating a new Jekyll 3 project.

agude added a commit to agude/agude.github.io that referenced this pull request Nov 20, 2016
jiahaog added a commit to jiahaog/jiahao.codes that referenced this pull request Jan 22, 2018
agude added a commit to agude/jekyll-theme that referenced this pull request Dec 27, 2021
agude added a commit to agude/jekyll-theme that referenced this pull request Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants