-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Poole 2 and Jekyll 3 #137
base: master
Are you sure you want to change the base?
Conversation
good stuff in there :) |
Thanks for this @mathiasvr. I made most of your updates and I'm very happy with the results. I don't have much experience in web dev, why is the baseurl change from "/" to "" in _config.yml a good idea? @qwtel - Very cool what you've done with your site, especially the sidebar. I did have a question on small screens... if you click on the menu icon to bring up the sidebar, there's no way to get the sidebar to disappear without refreshing or clicking on one of the sidebar links right? I was thinking of trying to implement something similar for my site but I think I'd either want the expanded sidebar to take up the entire screen (or moved to top) or I'd like to have some way to close out of it if covers other portions of the content (similar to lanyon but without actually moving the content to the right). |
Glad you like it :) It's still work in progress and currently assumes that you are using a touch device for the small screen layout. Closing the menu bar works via swiping to the left or tapping on the backdrop. Regarding your site, my current implementation should still work if you set |
@jjwesner The updated files are based on the current version of Poole which amongst other things sets the |
Changes based on: - poole/hyde/pull/97 - poole/hyde/pull/137
Changes based on: - poole/hyde/pull/97 - poole/hyde/pull/137
Changes based on: - poole/hyde/pull/97 - poole/hyde/pull/137
Hi, this PR brings in the changes from Poole 2 for Jekyll 3 support.
I know there are already a bunch of pending pull requests, but I am sharing this anyway in case somebody wants a working theme for Jekyll 3. Get the complete theme here.
Notes: