Sign with proper forkId #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't even... this crap took me like 5 hours...
martin-key
requested changes
Mar 22, 2018
|
Zo wish... |
|
Also your transaction loading thingy gets the txout hash mirror-reversed... Than it works (in some basic cases like signing with no more than one key) |
|
Please make an issue for that. I will not have time to look at it in the next week or so, but then I will.
… On 22 Mar 2018, at 11:46, Lukáš Nový ***@***.***> wrote:
Also your transaction loading thingy gets the txout hash mirror-reversed... Than it works (in some basic cases like signing with no more than one key)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADrjrT8DRWcQyNrKWRp6OrDOpp1d5rZUks5tg3LfgaJpZM4S2p4x>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't even... this crap took me like 5 hours...