Reduced mload in PrizeSplit #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierrickGT
approved these changes
Oct 14, 2021
| @@ -132,8 +132,7 @@ abstract contract PrizeSplit is IPrizeSplit, Ownable { | |||
| uint256 prizeSplitsLength = _prizeSplits.length; | |||
|
|
|||
| for (uint8 index = 0; index < prizeSplitsLength; index++) { | |||
| PrizeSplitConfig memory split = _prizeSplits[index]; | |||
| _tempTotalPercentage = _tempTotalPercentage + split.percentage; | |||
| _tempTotalPercentage = _tempTotalPercentage + _prizeSplits[index].percentage; | |||
There was a problem hiding this comment.
Suggested change
| _tempTotalPercentage = _tempTotalPercentage + _prizeSplits[index].percentage; | |
| _tempTotalPercentage += _prizeSplits[index].percentage; |
There was a problem hiding this comment.
I'm actually not sure this is cheaper since _prizeSplits is in storage, so each time we access _prizeSplits[index].percentage, it will cost us 200 in gas.
There was a problem hiding this comment.
either way it's one word
PierrickGT
suggested changes
Oct 14, 2021
| @@ -132,8 +132,7 @@ abstract contract PrizeSplit is IPrizeSplit, Ownable { | |||
| uint256 prizeSplitsLength = _prizeSplits.length; | |||
|
|
|||
| for (uint8 index = 0; index < prizeSplitsLength; index++) { | |||
| PrizeSplitConfig memory split = _prizeSplits[index]; | |||
| _tempTotalPercentage = _tempTotalPercentage + split.percentage; | |||
| _tempTotalPercentage = _tempTotalPercentage + _prizeSplits[index].percentage; | |||
There was a problem hiding this comment.
I'm actually not sure this is cheaper since _prizeSplits is in storage, so each time we access _prizeSplits[index].percentage, it will cost us 200 in gas.
asselstine
force-pushed
the
pool-1802-prizesplitsol_totalprizesplitpercentagea
branch
from
36ca245
to
4e1d565
Compare
asselstine
deleted the
pool-1802-prizesplitsol_totalprizesplitpercentagea
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: code-423n4/2021-10-pooltogether-findings#40