Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #46

Merged
merged 3 commits into from
Feb 18, 2020
Merged

Update #46

merged 3 commits into from
Feb 18, 2020

Conversation

gakada
Copy link
Contributor

@gakada gakada commented Jan 16, 2020

No description provided.

@gakada
Copy link
Contributor Author

gakada commented Feb 10, 2020

@KagamiChan this needs updating.

Though there are also some quests issues, e.g., in CSV:

235,【節分任務】鎮守府海域 南西方面防衛作戦

But in JSON:

    "game_id": 235,
    "name": "近海哨戒を実施せよ!",

@KagamiChan
Copy link
Member

Sorry for forgetting this thread

will take a look

@KagamiChan
Copy link
Member

The issue

  • poi db's quest record data gets corrupted somehow, the reason might be falsy reports or some Tanaka tricks
  • I chose to use that because it is the original source from game API, other records Wikia or kcwiki, may not match the text in some way

Given this I have to hold the quest name updates unless we change to a good way to record quests

btw, does tsundb have the quest name collection?

@KagamiChan
Copy link
Member

KagamiChan commented Feb 18, 2020

also this may be the issue from kcwiki data as the relationship between wiki numbering and API is maintained there

Do we have alternative source for that?

@KagamiChan KagamiChan merged commit 182dfa5 into poooi:master Feb 18, 2020
@lawvs
Copy link

lawvs commented Feb 18, 2020

Just for convenience, kcdata/quest uses kc3-translations as the game_id data source now. (poi db's quest record data need to decompress).

In theory, the data of KC3 should have consistent data with poi db, I want to know which data is correct.

@KagamiChan
Copy link
Member

Thanks @lawvs

That's a good source, we can see that for id 235, there're 235 and (legacy) 235SB38, seems 235SB38 came first, thus the new 235 should override it

@KagamiChan
Copy link
Member

KagamiChan commented Feb 18, 2020

So I think kcwiki data is correct, it's poi db's collection strategy that should change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants