-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update #46
Update #46
Conversation
@KagamiChan this needs updating. Though there are also some quests issues, e.g., in CSV:
But in JSON: "game_id": 235,
"name": "近海哨戒を実施せよ!", |
Sorry for forgetting this thread will take a look |
The issue
Given this I have to hold the quest name updates unless we change to a good way to record quests btw, does tsundb have the quest name collection? |
also this may be the issue from kcwiki data as the relationship between wiki numbering and API is maintained there Do we have alternative source for that? |
Just for convenience, kcdata/quest uses kc3-translations as the game_id data source now. (poi db's quest record data need to decompress). In theory, the data of KC3 should have consistent data with poi db, I want to know which data is correct. |
Thanks @lawvs That's a good source, we can see that for id 235, there're 235 and (legacy) 235SB38, seems 235SB38 came first, thus the new 235 should override it |
So I think kcwiki data is correct, it's poi db's collection strategy that should change |
No description provided.