Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mapping for the new Gigabyte Aorus Pro WiFi rev 1.2 #1

Merged
merged 1 commit into from
May 26, 2022

Conversation

13r0ck
Copy link

@13r0ck 13r0ck commented May 25, 2022

Requires pop-os/linux#141

This should work for all rear IO should now work (Mic/Speakers/Line-In/Toslink). Front Mic is still broken. Currently waiting on upstream to see if they have a solution. Though this should be good enough for us to start selling Thelio Major's until that is patched, because Thelios don't currently have front IO.

@XV-02
Copy link

XV-02 commented May 25, 2022

This resolves the issues on the rev 1.2 board, but not 1.1

@13r0ck 13r0ck force-pushed the pro-wifi-rev-1.2 branch 2 times, most recently from 920f705 to fcbd398 Compare May 26, 2022 03:02
@13r0ck
Copy link
Author

13r0ck commented May 26, 2022

@XV-02 This should not longer cause the regression on rev 1.1 by creating a separate map for each revision, and is ready for QA again

@XV-02
Copy link

XV-02 commented May 26, 2022

For ease of tracking, I'll refer to the joint testing of this and the intimately tied pop-os/linux#141 in this PR alone.

This resolved the issue with TOS link on the rev 1.2 board, and correctly updated the settings test-pane to expected behaviour. However, line in on rev 1.2 does not appear to be resolved yet.

The rev 1.1 regression is yet to be tested (due to system swap-out time), but can be if you wish it prioritized before your next steps.

Copy link

@XV-02 XV-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now functional on all products which should be effected!

@13r0ck 13r0ck merged commit 2192dc6 into master_jammy May 26, 2022
@13r0ck 13r0ck deleted the pro-wifi-rev-1.2 branch May 26, 2022 21:14
@13r0ck 13r0ck mentioned this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants