Fix app list icons #748
wiiznokesci.yml
on: pull_request
formatting
12s
linting
2m 46s
Annotations
1 error and 10 warnings
|
formatting
Process completed with exit code 1.
|
|
variant `OpenSettings` is never constructed:
cosmic-applet-notifications/src/lib.rs#L96
warning: variant `OpenSettings` is never constructed
--> cosmic-applet-notifications/src/lib.rs:96:5
|
84 | enum Message {
| ------- variant in this enum
...
96 | OpenSettings,
| ^^^^^^^^^^^^
|
= note: `Message` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
this function has too many arguments (9/7):
cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs#L24
warning: this function has too many arguments (9/7)
--> cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs:24:1
|
24 | // #[proxy(
25 | || interface = "org.freedesktop.Notifications",
26 | || default_service = "org.freedesktop.Notifications",
27 | || default_path = "/org/freedesktop/Notifications"
28 | || )]
| ||__- in this procedural macro expansion
... |
49 | | expire_timeout: i32,
50 | | ) -> zbus::Result<u32>;
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
= note: this warning originates in the attribute macro `proxy` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
this function has too many arguments (9/7):
cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs#L24
warning: this function has too many arguments (9/7)
--> cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs:24:1
|
24 | / #[proxy(
25 | | interface = "org.freedesktop.Notifications",
26 | | default_service = "org.freedesktop.Notifications",
27 | | default_path = "/org/freedesktop/Notifications"
28 | | )]
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: this warning originates in the attribute macro `proxy` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
cosmic-applet-audio/src/mpris_subscription.rs#L159
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> cosmic-applet-audio/src/mpris_subscription.rs:159:45
|
159 | players.sort_by(|a, b| a.name().cmp(&b.name()));
| ^^^^^^^^^ help: change this to: `b.name()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
cosmic-applet-audio/src/mpris_subscription.rs#L183
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> cosmic-applet-audio/src/mpris_subscription.rs:183:50
|
183 | self.players.sort_by(|a, b| a.name().cmp(&b.name()));
| ^^^^^^^^^ help: change this to: `b.name()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the following explicit lifetimes could be elided: 'a:
cosmic-applet-audio/src/mpris_subscription.rs#L274
warning: the following explicit lifetimes could be elided: 'a
--> cosmic-applet-audio/src/mpris_subscription.rs:274:22
|
274 | async fn find_active<'a>(players: &'a Vec<MprisPlayer>) -> Option<&'a MprisPlayer> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
cosmic-applet-audio/src/mpris_subscription.rs#L274
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> cosmic-applet-audio/src/mpris_subscription.rs:274:35
|
274 | async fn find_active<'a>(players: &'a Vec<MprisPlayer>) -> Option<&'a MprisPlayer> {
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&'a [MprisPlayer]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
cosmic-applet-audio/src/pulse.rs#L27
warning: very complex type used. Consider factoring parts into `type` definitions
--> cosmic-applet-audio/src/pulse.rs:27:24
|
27 | pub static FROM_PULSE: Lazy<Mutex<Option<(mpsc::Receiver<Message>, mpsc::Sender<Message>)>>> =
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
called `map(..).flatten()` on `Iterator`:
cosmic-applet-notifications/src/lib.rs#L299
warning: called `map(..).flatten()` on `Iterator`
--> cosmic-applet-notifications/src/lib.rs:299:47
|
299 | for n in self.cards.drain(..).map(|n| n.1).flatten() {
| ^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|n| n.1)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten
= note: `#[warn(clippy::map_flatten)]` on by default
|
|
non-binding `let` on a future:
cosmic-applet-audio/src/lib.rs#L456
warning: non-binding `let` on a future
--> cosmic-applet-audio/src/lib.rs:456:25
|
456 | / _ = tokio::spawn(async move {
457 | | tokio::time::sleep(tokio::time::Duration::from_secs(30)).await;
458 | | conn.send(pulse::Message::UpdateConnection);
459 | | });
| |__________________________^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
= note: `#[warn(clippy::let_underscore_future)]` on by default
|