Use cosmic-settings-subscriptions for some iced subscriptions
#492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With pop-os/cosmic-settings-subscriptions@29b8d3f, changing the keyboard backlight with keybindings now is reflected in the applet while the applet is open. Though looks like that will need more fixes here to make sure it behaves cleanly when changing the keyboard backlight with the slider in the applet. That isn't hugely important, but is generally good, and something the OSD will need. |
mmstick
approved these changes
Jun 14, 2024
ids1024
force-pushed
the
cosmic-settings-subscriptions
branch
from
6228b8f
to
e132917
Compare
These should be useful in `cosmic-osd` as well.
There's no need to deviate from a functional pattern here.
Fixes #301. Should be combined with the subscription code here to avoid duplication, and two things using pulse.
This shares a subscription with cosmic-osd, avoiding some duplication. It's also important that things like selection of the display brightness device are done consistency, and handling this in cosmic-settings-daemon is one way to ensure consistency.
Being able to define sliders this way seems like an advantage of using a seperate `brightness`/`max_brightness` instead of a float. Now the `step` of the slider is a single unit as supported by the display.
ids1024
force-pushed
the
cosmic-settings-subscriptions
branch
from
e132917
to
6358548
Compare
This makes sure we can listen to brightness subscription and set the brightness without conflicts or weird workarounds.
|
This and pop-os/cosmic-osd#44 should now be good to improve various issues, avoid duplication, and ensure consistency between applets and OSDs. Some things could be refactored a bit still, but that can be done later. |
mmstick
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cosmic-appletsandcosmic-osdboth have some iced subscription code that could be useful in the other, so a library to share this makes sense.Also we should avoid duplicating dbus bindings that are present in
dbus-settings-bindings. (Currentlycosmic-settings-subscriptionsis using a branch ofdbus-settings-bindings, pending pop-os/dbus-settings-bindings#15.)This should help to address several open issues in cosmic-applets and cosmic-osd.