Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applet processes sometimes outlive panel #2

Closed
ids1024 opened this issue Jun 11, 2022 · 1 comment · Fixed by pop-os/xdg-shell-wrapper#5
Closed

Applet processes sometimes outlive panel #2

ids1024 opened this issue Jun 11, 2022 · 1 comment · Fixed by pop-os/xdg-shell-wrapper#5

Comments

@ids1024
Copy link
Member

ids1024 commented Jun 11, 2022 •
edited
Loading

This stands out since the applets using GApplication don't show up when the panel is started again.

Maybe the way the Wayland socket is being created could be done differently so that an EPIPE is generated? Or if subprocesses could be killed when the panel stops...

But then, stopping with ctrl+c doesn't generally seem to have this issue, so I don't know exactly in what cases this happens...
@ids1024
Copy link
Member Author

ids1024 commented Jun 29, 2022

Okay, this happens whenever the compositor is killed while cosmic-panel is running, so at least it's reproducible.

ids1024 added a commit to pop-os/xdg-shell-wrapper that referenced this issue Jun 29, 2022
@ids1024
Don't unset cloexec on server end of wayland sockets
9cbfdf1 
This can prevent cosmic-panel applets closing. Presumably they didn't
receive an EOF from the socket since other applets got a copy of the
server-end fd.

As far as I can tell there's no reason to do this, for the server end of
the socket. It seems to work find with this code removed.

Fixes pop-os/cosmic-panel#2.
@ids1024 ids1024 mentioned this issue Jun 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't unset cloexec on server end of wayland sockets pop-os/xdg-shell-wrapper
1 participant
@ids1024