Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch unicode-linebreak to xi-unicode for ~25% faster debug builds #6

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

kettle11
Copy link
Contributor

Further details in the original issue: #2

@kettle11 kettle11 changed the title Switch unicode-linebreak to xi-unicode for ~25% faster builds Switch unicode-linebreak to xi-unicode for ~25% faster debug builds Oct 23, 2022
Copy link
Member

@jackpot51 jackpot51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jackpot51 jackpot51 merged commit c1262ec into pop-os:main Oct 23, 2022
@jackpot51
Copy link
Member

Please comment on #7 if you agree.

@jackpot51
Copy link
Member

https://docs.rs/xi-unicode/latest/xi_unicode/struct.LineBreakIterator.html appears to break on the ZJW character, used in sample/emoji-zjw.txt

@jackpot51
Copy link
Member

I have reverted for now. Hopefully this can be fixed in the future.

@kettle11
Copy link
Contributor Author

Ah, too bad. It appears it's this bug: xi-editor/xi-editor#1322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants