Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More App Library Changes #259

Merged
merged 3 commits into from
Dec 9, 2021
Merged

More App Library Changes #259

merged 3 commits into from
Dec 9, 2021

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Dec 9, 2021

@ids1024
improv: Add spacing to "Type to search"
48f6281 
Matches Pop Shell.
@ids1024
fix: Only grab key focus if mapped
69c9013 
You'd think this restriction would already be enforced in Clutter...

Should fix pop-os/beta#333
@ids1024
improv: Disable "Available to Install" if dbus service not available
76ef31c 
Still appears (and doesn't work) if `io.elementary.appcenter` is started
without `-s`, which doesn't expose the object but does claim the dbus
name.
@ids1024 ids1024 requested review from a team December 9, 2021 20:13
@13r0ck 13r0ck mentioned this pull request Dec 9, 2021
Closed
13r0ck
13r0ck approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@13r0ck 13r0ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the issue reliably by rebooting, then opening a terminal as fast as possible. Then in about 15 seconds the focus would be stolen.

After installing this fix, the focus wasn't stolen in any of 5 attempts afterwards.

leviport
leviport approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also seeing the other two bullet points working as expected.

@mmstick mmstick merged commit 9263ad3 into master_impish Dec 9, 2021
@mmstick mmstick deleted the app-library_impish branch December 9, 2021 22:44
This was referenced Dec 10, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@13r0ck 13r0ck 13r0ck approved these changes

@leviport leviport leviport approved these changes

@crawfxrd crawfxrd crawfxrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ids1024 @crawfxrd @leviport @13r0ck @mmstick