Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaged version doesn't respect language settings #4

Closed
jacobgkau opened this issue Dec 2, 2020 · 2 comments · Fixed by #5
Closed

Packaged version doesn't respect language settings #4

jacobgkau opened this issue Dec 2, 2020 · 2 comments · Fixed by #5
Labels
bug Something isn't working

Comments

@jacobgkau
Copy link
Member

jacobgkau commented Dec 2, 2020

The extension's right-click menu and preferences dialog do not respect the system's language settings (they are always in English, even if the language was changed in Settings -> Region & Language and the session was restarted.) If I install the extension from extensions.gnome.org, it does respect the language settings.

Tested with Portuguese (Brazil) and French, both of which have translation files in the package.

@ids1024
Copy link
Member

ids1024 commented Dec 2, 2020

Strange. The translation files are installed, and work in Python:

import gettext
gettext.translation('ding', languages=['es']).gettext('Show a context menu item to delete permanently')

I guess it isn't loading translations from the normal system directory for some reason...

@ids1024
Copy link
Member

ids1024 commented Dec 2, 2020

Ah yes, I suppose it's the way the bindtextdomain call is written. Should be easy to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants