Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propogate some more errors #284

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Propogate some more errors #284

merged 1 commit into from
Jan 25, 2022

Conversation

13r0ck
Copy link
Contributor

@13r0ck 13r0ck commented Jan 25, 2022 •
edited
Loading

Propagates these possible errors rather than panicking.

Should close #285, to be clear this PR doesn't prevent the install from failing, but the user should get an error rather than the installer just crashing

@13r0ck 13r0ck requested review from a team January 25, 2022 02:37
jacobgkau
jacobgkau approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recreated #285, can confirm the installer now shows the failure/error instead of crashing/closing.

@mmstick mmstick merged commit fcb482b into master Jan 25, 2022
@mmstick mmstick deleted the propogate-errors branch January 25, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobgkau jacobgkau jacobgkau approved these changes

@mmstick mmstick mmstick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selecting partitions can crash installer
3 participants
@13r0ck @mmstick @jacobgkau