Fix parsing of "ubuntu-drivers list --recommended" output #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command uses different separators when passing the "--recommended" flag. This adjusts the code so that multi-package and multi-line output can both be parsed correctly.
jlnr
commented
Sep 8, 2023
jackpot51
approved these changes
Sep 8, 2023
jacobgkau
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #320, based on discussion here elementary/os#686 (comment)
"ubuntu-drivers" uses different separators when passing the "--recommended" flag, so the current
split(",")breaks when more than one package name is being returned. This PR adjusts the code so that multi-package and multi-line output can both be parsed correctly.