Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing Icons and symlinks #123

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Fix missing Icons and symlinks #123

merged 3 commits into from
Aug 4, 2022

Conversation

isantop
Copy link
Contributor

@isantop isantop commented Aug 3, 2022

There were two items whose entries in the symlinks files were backwards, causing rendering issues and deleting the rendered files. This fixes this and re-renders the theme to include the icons (help-about and preferences-bluetooth)

@isantop
fix(symlinks): fix errant symlinks
39f3514 
These were deleting files from the icon theme, causing them to be
re-rendered every time and then get deleted during the symlink pass.
This fixes this issue
@isantop
fix(generate-symlinks): improve command output
cf85aeb 
Suppress the symlink deletion, as it's generally not relevant and spams
up the output.
@isantop
chore(render): render with fixed theme
8e64bc1
@isantop isantop added the bug Something isn't working label Aug 3, 2022
@isantop isantop requested review from a team August 3, 2022 21:18
@isantop isantop self-assigned this Aug 3, 2022
@n3m0-22 n3m0-22 self-assigned this Aug 3, 2022
@n3m0-22
Copy link
Contributor

n3m0-22 commented Aug 3, 2022

I'm seeing the new icons in the directories, and I can see the help-about icon. I can't seem to find the preferences-system-bluetooth / preferences-bluetooth anywhere. I'm checking launcher and in gtk-icon-browser. Where should I be seeing this change?

@isantop
Copy link
Contributor Author

isantop commented Aug 4, 2022

@n3m0-22 The icons are showing up in gtk3-icon-browser for bluetooth-active and bluetooth-disabled. I believe they're being loaded because of fallback logic, rather than because those are the correct icons. There should probably be icons for those (linking the current icon would be good for the -active icon, and a simple change could be made for the disabled one), but I think that's out-of-scope for this PR.

n3m0-22
n3m0-22 approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@n3m0-22 n3m0-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing with gtk3-icon-browser this looks good.

@n3m0-22 n3m0-22 merged commit a68321e into master Aug 4, 2022
@leviport leviport deleted the fix-symlinks branch August 4, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3m0-22 n3m0-22 n3m0-22 approved these changes

@13r0ck 13r0ck 13r0ck approved these changes

Assignees

@isantop isantop

@n3m0-22 n3m0-22

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isantop @n3m0-22 @13r0ck