fix: add case independent startup_wm_class, name fallback #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanabx
force-pushed
the
fixes/more-appid-fallbacks
branch
2 times, most recently
from
4fe77d9
to
75ca322
Compare
ryanabx
force-pushed
the
fixes/more-appid-fallbacks
branch
from
75ca322
to
38dd70a
Compare
ryanabx
changed the title
ryanabx
changed the title
ryanabx
changed the title
Drakulix
approved these changes
Mar 11, 2024
wash2
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a "name" fallback and changes the startup_wm_class fallback to evaluate independent of case.
Some applications (like element desktop) have a app id capitalized e.g. "Element" when their startup_wm_class is lowercase e.g. "element".
The "name" fallback is separate from the startup_wm_class and appid conditions just in case an app is named something similar to another app's id.
Apps known by me to be fixed by the case insensitive wm_class fallback:
Apps known by me to be fixed by the name fallback:
This should fix part (or potentially all) of this issue, this issue, and this issue
I believe this is similar to what other DEs do to handle problematic apps that don't register their app-id properly.