fix: Don't use last_focused state in handling notify::focus-window #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 18, 2021
lhotari
force-pushed
the
lh-fix-intellij-issue
branch
from
0b5ce53
to
e800c28
Compare
lhotari
changed the title
cesarrew
approved these changes
Jun 18, 2021
There was a problem hiding this comment.
I've manually changed the file "/usr/share/gnome-shell/extensions/pop-shell@system76.com/extension.js" with this fix and, after that, I could't reproduce the problem anymore. I't seems fixed. Thank you a lot @lhotari!
jacobgkau
approved these changes
Jun 18, 2021
There was a problem hiding this comment.
Confirmed this fixes #712. This does not fix #970 according to my testing.
Regression testing passed:
shell-pr1007-focal.txt
shell-pr1007-hirsute.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #712
The solution is based on comments made by @sitepodmatt in #712 (comment) about the root cause of the issue.
This solution ignores last_focused state in handling notify::focus-window event.