fix: allow search/launcher hotkeys to work while capslock is on #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmstick
approved these changes
Jan 17, 2023
n3m0-22
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only lower-case character codes were considered in hotkeys related to the search/launcher:
This PR allows capslock to be on (or shift held down) while pressing hotkeys, and the same expected actions will occur.
Note that this also helps clean up the numeric constants used as key codes, and replaces them with easier-to-read key names.
Other hotkeys that may be affected (and would be worth testing) include:
Fixes pop-os/launcher#102