Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move gjs from DEFAULT_FLOAT_RULES to SKIPTASKBAR_EXCEPTIONS #1605

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

GloriousEggroll
Copy link
Contributor

When pop-shell is installed alongside desktop-icons NG and "Show Minimize to Tray Windows" is enabled, gjs shows up as an application in the alt-tab menu (like in this previous bug: #1056). By completely moving it to the SKIPTASKBAR_EXCEPTIONS it gets resolved/no longer shows up when the option is enabled.

When pop-shell is installed alongside desktop-icons NG and "Show Minimize to Tray Windows" is enabled, gjs shows up as an application in the alt-tab menu (like in this previous bug: pop-os#1056). By completely moving it to the SKIPTASKBAR_EXCEPTIONS it gets resolved/no longer shows up when the option is enabled.
@mmstick mmstick requested a review from a team April 3, 2023 15:29
@n3m0-22 n3m0-22 self-assigned this Apr 4, 2023
Copy link
Contributor

@n3m0-22 n3m0-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the issue, and this does seem to fix it.

I found no regressions while testing. Looks good to me.

shell-testing.txt

@mmstick mmstick merged commit a3a1b7b into pop-os:master_jammy Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants