Improve search order based display name containing pattern #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaryrawr
changed the title
scaryrawr
commented
Dec 3, 2020
| return a_name.toLowerCase() > b_name.toLowerCase() ? 1 : 0; | ||
| const pattern_lower = pattern.toLowerCase() | ||
|
|
||
| const a_includes = a_name.includes(pattern_lower); |
There was a problem hiding this comment.
@mmstick would indexOf be better here? We could also sort by "how close to start" the position is. I think it's probably not worth doing unless folks still feel the result order needs improving.
There was a problem hiding this comment.
Ultimately, I've planned to switch to using the levenshtein distance algorithm to compare and weight results.
jacobgkau
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
Good improvement to search results. Regression testing passed.
shell-pr753-groovy.txt
shell-pr753-focal.txt
Discovered an unrelated issue #762 while testing (not a regression.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108
Same with things like Steam or Edge
