Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/remove poppinss utils #2

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Conversation

thetutlage
Copy link
Member

Proposed changes

The @poppinss/utils@5.0 package is quite heavy, since it pulls down the entire lodash library. Inside this repo, we were only using the Exception class from the utils package and I have replaced that with Error class.

The Exception class allowed assigning a unique error code to all the errors. However, with Error class we are not able to do so. That is the only downside of remove the utils package.

@Julien-R44 If you think, this will not impact your usage, then we can go ahead and merge this change.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Julien-R44
Copy link
Member

Julien-R44 commented Mar 14, 2023

No problem for me!! Thanks for asking 👍

@Julien-R44 Julien-R44 merged commit 648b5f0 into develop Mar 14, 2023
@Julien-R44 Julien-R44 deleted the refactor/remove-poppinss-utils branch March 14, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants