Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORT-8073 | Update launchdarkly github action guide #1204

Merged
merged 10 commits into from
May 23, 2024

Conversation

mk-armah
Copy link
Member

Description

Updated docs pages

/create-self-service-experiences/setup-backend/github-workflow/examples/Launchdarkly/toggle-launchdarkly-feature-flag

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1204.d2ngvl90zqbob8.amplifyapp.com

@mk-armah mk-armah changed the title Update launchdarkly github action guide PORT-8073 | Update launchdarkly github action guide May 15, 2024
Comment on lines 297 to 300
"blueprint": "{{.action.blueprint}}",
"entity": "{{.entity.identifier}}",
"run_id": "{{.run.id}}",
"relations": "{{.entity.relations}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the indentation

@@ -294,37 +293,11 @@ Create a new self service action using the following JSON configuration.
"{{if (.inputs | has(\"project_key\")) then \"project_key\" else null end}}": "{{.inputs.\"project_key\"}}",
"{{if (.inputs | has(\"environment_key\")) then \"environment_key\" else null end}}": "{{.inputs.\"environment_key\"}}",
"{{if (.inputs | has(\"flag_state\")) then \"flag_state\" else null end}}": "{{.inputs.\"flag_state\"}}",
Copy link
Contributor

@pazhersh pazhersh May 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be enough:

Suggested change
"{{if (.inputs | has(\"flag_state\")) then \"flag_state\" else null end}}": "{{.inputs.\"flag_state\"}}",
""flag_state": "{{.inputs."flag_state"}}",

@pazhersh pazhersh merged commit 1feff13 into main May 23, 2024
2 checks passed
@pazhersh pazhersh deleted the update/launchdarkly-action-inputs branch May 23, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants