mistral 7b LLM addon #263
Merged
mistral 7b LLM addon #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferozemohideen
approved these changes
Jun 13, 2024
porter/v1/addons.proto
Outdated
| } | ||
| // helm_overrides is stringified json of raw Helm overrides to use for the addon. These will override any values generated by the contract. | ||
| HelmOverrides helm_overrides = 13; | ||
| HelmOverrides helm_overrides = 20; |
There was a problem hiding this comment.
I was going for readability. It reads better when the numbers are ascending. But it is not worth making this a breaking change. For the future, it is better to just spread these numbers out if we expect to make changes like this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.